fix: disable route check for po cleanup test cases #21320
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cyw233
force-pushed
the
disable-route-checkf-for-po-cleanup
branch
from
4a27059 to
3762ab5
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cyw233
force-pushed
the
disable-route-checkf-for-po-cleanup
branch
from
3762ab5 to
467db16
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
We are having a module level
pytest.mark.disable_route_checkmarker inpc/test_po_cleanup.pytest to temporarily disable the routeCheck monitor for the entire module. However, we are doingconfig_reload()in different test cases within this test module, and the routeCheck monitor will automatically startup after eachconfig_reload().Therefore, we want to keep the module level routeCheck disable marker (so the routeCheck monitor will always be started at the very end of the test module) and introduce an extra function-level routeCheck disable fixture to make sure the routeCheck monitor is always disabled before each test case.
Summary:
Fixes # (issue) Microsoft ADO 35884974
Type of change
Back port request
Approach
What is the motivation for this PR?
Disable the routeCheck monitor before each test case in
pc/test_po_cleanup.pyto avoid getting any noisy error syslog.How did you do it?
Introduced a function-level fixture to disable routeCheck monitor.
How did you verify/test it?
I ran the updated code and can confirm it's working well: https://elastictest.org/scheduler/testplan/6916acddbf375d1f9e5d1333
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation